From shaun@inerd.com Fri May 19 02:45:21 2006 Return-Path: Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9946116A42A for ; Fri, 19 May 2006 02:45:21 +0000 (UTC) (envelope-from shaun@inerd.com) Received: from dione.picobyte.net (host-212-158-207-124.bulldogdsl.com [212.158.207.124]) by mx1.FreeBSD.org (Postfix) with SMTP id 0434F43D49 for ; Fri, 19 May 2006 02:45:20 +0000 (GMT) (envelope-from shaun@inerd.com) Received: from charon.picobyte.net (charon.picobyte.net [IPv6:2001:4bd0:201e::fe03]) by dione.picobyte.net (Postfix) with ESMTP for ; Fri, 19 May 2006 03:45:18 +0100 (BST) Message-Id: <1148006718.8503@charon.picobyte.net> Date: Fri, 19 May 2006 03:45:18 +0100 From: Shaun Amott Reply-To: Shaun Amott To: FreeBSD-gnats-submit@freebsd.org Cc: Subject: [PATCH] Porter's Handbook: clarify why OPTIONS need testing the way they do X-Send-Pr-Version: 3.113 X-GNATS-Notify: >Number: 97477 >Category: docs >Synopsis: [PATCH] Porter's Handbook: clarify why OPTIONS need testing the way they do >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-doc >State: closed >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Fri May 19 02:50:12 GMT 2006 >Closed-Date: Sun Jun 04 19:17:17 GMT 2006 >Last-Modified: Sun Jun 04 19:17:17 GMT 2006 >Originator: Shaun Amott >Release: FreeBSD 6.1-STABLE i386 >Organization: >Environment: >Description: It has recently come to light that the note about having to test OPTIONS in a particular way does not provide an adequete explanation as to what the problem is. Therefore, I propose the following minor addition in order to help clear things up. I twiddled the punctuation a bit in the shifted 'Due to a deficiency...' statement, because it was difficult to read. >How-To-Repeat: >Fix: --- book.sgml.diff begins here --- Index: book.sgml =================================================================== RCS file: /home/ncvs/doc/en_US.ISO8859-1/books/porters-handbook/book.sgml,v retrieving revision 1.709 diff -u -r1.709 book.sgml --- book.sgml 18 May 2006 05:05:30 -0000 1.709 +++ book.sgml 19 May 2006 02:17:40 -0000 @@ -3825,12 +3825,20 @@ the inclusion of bsd.port.pre.mk. The WITH_* and WITHOUT_* variables can only be tested after the inclusion of - bsd.port.pre.mk. Due to a deficiency - in the infrastructure, you can only test - WITH_* variables for options, which are + bsd.port.pre.mk. + + + Due to a deficiency in the infrastructure, you can only test + WITH_* variables for options which are OFF by default, and - WITHOUT_* variables for options, which - defaults to ON. + WITHOUT_* variables for options which + default to ON. The reason for this is + that when packages are built on the build cluster, or if + BATCH is defined, the config + target is not run, and therefore no OPTIONS + are defined. This would cause make depends and + make describe to break for ports not following + the aforementioned rule. Example --- book.sgml.diff ends here --- >Release-Note: >Audit-Trail: State-Changed-From-To: open->closed State-Changed-By: pav State-Changed-When: Sun Jun 4 19:17:09 UTC 2006 State-Changed-Why: Committed, thanks! http://www.freebsd.org/cgi/query-pr.cgi?pr=97477 >Unformatted: